[AbsInt] Improve implementation of abstract domains#2485
Open
OliverGerstl wants to merge 8 commits into
Open
Conversation
EagleoutIce
reviewed
Jul 9, 2026
EagleoutIce
left a comment
EagleoutIce
left a comment
Member
There was a problem hiding this comment.
Just a quick pass for now, i have not yet checked whether all changes are applied consistently but the gneeral change looks clear :)
| @@ -4,18 +4,17 @@ import { SetRangeDomain } from '../domains/set-range-domain'; | |||
|
|
|||
| /** The type of the abstract product representing the shape of data frames */ | |||
| export type AbstractDataFrameShape = { | |||
Member
There was a problem hiding this comment.
why not have it as an interface?
| case NumericalComparator.Equal: { | ||
| if(this.isValue() && this.value[0] <= value && value <= this.value[1]) { | ||
| return this.value[0] === this.value[1] ? Ternary.Always : Ternary.Maybe; | ||
| if(this.isValue() && this.lower <= value && value <= this.upper) { |
Member
There was a problem hiding this comment.
so we consistently consider top to be a value but bottom to be no value?
| /** | ||
| * Represents the different types of set comparators for satisfiability checks for an abstract domain. | ||
| */ | ||
| export enum SetComparator { |
Member
There was a problem hiding this comment.
maybe also an interest of Intersect and NoIntersect? Especially if we want to blacklis some results?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.